Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: [IOBP-1096] Replace legacy markdown component for IDPay #6585

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

refactor: [IOBP-1096] Replace legacy markdown component for IDPay #6585

wants to merge 5 commits into from
+11 −55

Conversation

LeleDallas
Copy link
Contributor

Short description

This pull request includes several changes to the idpay feature components, focusing on replacing the LegacyMarkdown component with the new IOMarkdown component.

List of changes proposed in this pull request

How to test

Ensure that all legacy IDPay markdown components are aligned with the established design requirements

@LeleDallas LeleDallas added the IO-Bonus e pagamenti IO - Bonus e pagamenti label Jan 3, 2025
@LeleDallas LeleDallas self-assigned this Jan 3, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 3, 2025 •
edited
Loading

Jira Pull Request Link

This Pull Request refers to the following Jira issue IOBP-1096

@Vangaorth
Copy link
Contributor

Is not this a duplicate of #6445?

@codecov Codecov
Copy link

codecov bot commented Jan 3, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 40.33%. Comparing base (b207270) to head (953f9d9).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...pay/onboarding/screens/InitiativeDetailsScreen.tsx 0.00% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (b207270) and HEAD (953f9d9). Click for more details.

HEAD has 6 uploads less than BASE
Flag BASE (b207270) HEAD (953f9d9)
12 6
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6585      +/-   ##
==========================================
- Coverage   49.30%   40.33%   -8.98%     
==========================================
  Files        1565     1557       -8     
  Lines       32223    32082     -141     
  Branches     7288     7242      -46     
==========================================
- Hits        15887    12939    -2948     
- Misses      16298    19109    +2811     
+ Partials       38       34       -4
Files with missing lines Coverage Δ
...dpay/details/components/InitiativeRulesInfoBox.tsx 30.00% <ø> (ø)
...rding/components/OnboardingDescriptionMarkdown.tsx 33.33% <ø> (+19.04%) ⬆️
...pay/onboarding/screens/PDNDPrerequisitesScreen.tsx 9.52% <ø> (ø)
...pay/onboarding/screens/InitiativeDetailsScreen.tsx 10.00% <0.00%> (+0.90%) ⬆️

... and 248 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c8f237...953f9d9. Read the comment docs.

@LeleDallas
Copy link
Contributor Author

Is not this a duplicate of #6445?

Yes, it's similar, but this one is listed in the B&P board as a refactor task for the IDPay screen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrisMattew ChrisMattew Awaiting requested review from ChrisMattew ChrisMattew is a code owner

@gispada gispada Awaiting requested review from gispada gispada is a code owner

@freddi301 freddi301 Awaiting requested review from freddi301 freddi301 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@LeleDallas LeleDallas

Labels
IO-Bonus e pagamenti IO - Bonus e pagamenti
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LeleDallas @Vangaorth